-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toolbar refactor #8158
Toolbar refactor #8158
Conversation
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
through templates in hierarchical grid
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
Change the interaction for column hiding UI. Updated tests. Closes #6858
Toolbar actions are rendered once the grid is 'fully' loaded in order to prevent expression changed after checked errors caused by updating the column collection. More unit tests updates.
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
}; | ||
|
||
const moveTemplateIfAny = (grid: Element) => { | ||
const ngTemplates = findElementNodes([grid], ['ng-template']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible for the template to be using the short syntax (<div *igxToolbarCustomContent...
) that won't be found searching for just ng-template
. As far as I see most of our code examples are covered, but to be thorough, try to capture both versions if it doesn't get too messy.
projects/igniteui-angular/src/lib/grids/toolbar/grid-toolbar-hiding.component.html
Outdated
Show resolved
Hide resolved
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
…into rkaraivanov/toolbar-refactor
…iteUI/igniteui-angular into rkaraivanov/toolbar-refactor
Closes #8055
Closes #7924
Closes #6858
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)